Exclude transitive artifacts already part of orc-core fat jar #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fyi, this seems like a problem orc-core should fix at its end also. I've filed a ticket there as well https://issues.apache.org/jira/browse/ORC-530 |
Fokko
added a commit
that referenced
this pull request
Aug 22, 2023
* Python: Support add column * Add integration tests (#264) * Python: Support add column * Add the requirement (#265) * Python: Support add column --------- Co-authored-by: Fokko Driesprong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are relocating hive classes in spark-runtime artifact. These relocated classes are not part our dependency graph. [Shadow plugin has this issue]. These Hive classes are coming from hive-storage-api artifact which is a transitive dependency of orc-core. orc-core, being a fat jar, already includes hive-storage-api and protobuf-java jars, which are already shaded. A simple fix in this case is to exclude storage-api from orc-core as this is already part of orc-core
Fixes #260
Note: protobuf is also excluded just because it is already part of orc-core. It is not related to the issue reported in #260